Formalize your Pull Request etiquette.
What is Danger JS?
Danger runs after your CI, automating your team's conventions surrounding code review.
This provides another logical step in your process, through which Danger can help lint your rote tasks in daily code review.
You can use Danger to codify your teams norms, leaving humans to think about harder problems.
Danger JS works with GitHub or BitBucket Server for code review, then with: Travis CI, Circle CI, GitHub Actions, Semaphore, Jenkins, Docker Cloud, Bitrise, surf-build, Codeship, Drone, Buildkite, Nevercode, buddybuild, TeamCity, Visual Studio Team Services, Screwdriver, Concourse, Netlify or CodeBuild.
- Enforce CHANGELOGs
- Enforce links to Trello/JIRA in PR/MR bodies
- Enforce using descriptive labels
- Look out for common anti-patterns
- Highlight interesting build artifacts
- Give warnings when specific files change
Danger provides the glue to let you build out the rules specific to your team's culture, offering useful metadata and a comprehensive plugin system to share common issues.
Alright. So, actually, you may be in the wrong place. From here on in, this README is going to be for people who are interested in working on and improving on Danger JS.
We keep all of the end-user documentation at http://danger.systems/js.
Some quick links to get you started:
This thing is broken, I should help improve it!
Awesommmmee. Everything you need is down below. You can also refer to CONTRIBUTING file where you'll find the same information listed below.
git clone https://github.com/danger/danger-js.gitcd danger-js# if you don't have yarn installednpm install -g yarnyarn install
You can then verify your install by running the tests, and the linters:
yarn testyarn lint
The fixers for both tslint and prettier will be applied when you commit, and on a push your code will be verified that it compiles.
You can run your dev copy of danger against a PR by running:
yarn build; node --inspect distribution/source/commands/danger-pr.js https://github.com/danger/danger-js/pull/817
How does Danger JS work?
Check the architecture doc.
What is the TODO?
Check the issues, I try and keep my short term perspective there. Long term is in the VISION.md.
Releasing a new version of Danger
Following this commit as a model:
- Checkout the
masterbranch. Ensure your working tree is clean, and make sure you have the latest changes by running
- Publish -
npm run release -- [major/patch/minor] --non-interactive.
License, Contributor's Guidelines and Code of Conduct
We try to keep as much discussion as possible in GitHub issues, but also have a pretty inactive Slack --- if you'd like an invite, ping @Orta a DM on Twitter with your email. It's mostly interesting if you want to stay on top of Danger without all the emails from GitHub.
This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs.
This project subscribes to the Moya Contributors Guidelines which TLDR: means we give out push access easily and often.