Navigation Menu

Skip to content

Remote code execution via the `pretty` option.

High severity GitHub Reviewed Published Feb 28, 2021 in pugjs/pug • Updated Feb 1, 2023

Package

npm pug (npm)

Affected versions

< 3.0.1

Patched versions

3.0.1
npm pug-code-gen (npm)
< 2.0.3
>= 3.0.0, < 3.0.2
2.0.3
3.0.2

Description

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to pug@3.0.1 or pug-code-gen@3.0.2 or pug-code-gen@2.0.3, which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: pugjs/pug#3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy

References

@ForbesLindesay ForbesLindesay published to pugjs/pug Feb 28, 2021
Reviewed Mar 3, 2021
Published to the GitHub Advisory Database Mar 3, 2021
Published by the National Vulnerability Database Mar 3, 2021
Last updated Feb 1, 2023

Severity

High

Weaknesses

CVE ID

CVE-2021-21353

GHSA ID

GHSA-p493-635q-r6gr

Source code

No known source code
Checking history
See something to contribute? Suggest improvements for this vulnerability.